The following document contains the results of FindBugs Report
FindBugs Version is 2.0.0
Threshold is medium
Effort is min
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.universAAL.ri.gateway.communicator.Activator.bc isn't final and can't be protected from malicious code | MALICIOUS_CODE | MS_CANNOT_BE_FINAL | Not available | Medium |
| org.universAAL.ri.gateway.communicator.Activator.mc isn't final and can't be protected from malicious code | MALICIOUS_CODE | MS_CANNOT_BE_FINAL | Not available | Medium |
| Write to static field org.universAAL.ri.gateway.communicator.Activator.bc from instance method org.universAAL.ri.gateway.communicator.Activator.start(BundleContext) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 70 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of Message.content in org.universAAL.ri.gateway.communicator.service.Message.equals(Object) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 84 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.universAAL.ri.gateway.communicator.service.impl.CommunicatorStarter.properties should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Not available | Medium |
| Null passed for nonnull parameter of java.util.Properties.getProperty(String) in org.universAAL.ri.gateway.communicator.service.impl.CommunicatorStarter.convertSecurityPropertiesToObjectNotation(Type, SecurityAction) | CORRECTNESS | NP_NULL_PARAM_DEREF | 227 | Medium |
| org.universAAL.ri.gateway.communicator.service.impl.CommunicatorStarter.loadConfiguration() may fail to clean up java.io.InputStream | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 174 | Medium |
| org.universAAL.ri.gateway.communicator.service.impl.CommunicatorStarter.loadConfiguration() may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 174 | Medium |
| exceptional return value of java.io.File.mkdirs() ignored in org.universAAL.ri.gateway.communicator.service.impl.CommunicatorStarter.loadConfiguration() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 171 | Medium |
| Unread field: org.universAAL.ri.gateway.communicator.service.impl.CommunicatorStarter.context | PERFORMANCE | URF_UNREAD_FIELD | 92 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.universAAL.ri.gateway.communicator.service.impl.EncryptionWrapper.getPayload() may expose internal representation by returning EncryptionWrapper.payload | MALICIOUS_CODE | EI_EXPOSE_REP | 39 | Medium |
| new org.universAAL.ri.gateway.communicator.service.impl.EncryptionWrapper(byte[]) may expose internal representation by storing an externally mutable object into EncryptionWrapper.payload | MALICIOUS_CODE | EI_EXPOSE_REP2 | 33 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.universAAL.ri.gateway.communicator.service.impl.GatewayAddress.PROTOCOL; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 28 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of profiles in org.universAAL.ri.gateway.communicator.service.impl.GatewayCommunicatorImpl.handleMessage(InputStream, OutputStream) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 505 | Medium |
| Nullcheck of cpe at line 532 of value previously dereferenced in org.universAAL.ri.gateway.communicator.service.impl.GatewayCommunicatorImpl.handleMessage(InputStream, OutputStream) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 532 | Medium |
| Exception is caught when Exception is not thrown in org.universAAL.ri.gateway.communicator.service.impl.GatewayCommunicatorImpl.handleMessage(InputStream, OutputStream) | STYLE | REC_CATCH_EXCEPTION | 662 | Medium |
| Switch statement found in org.universAAL.ri.gateway.communicator.service.impl.GatewayCommunicatorImpl.handleMessage(InputStream, OutputStream) where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 464-472 | Medium |
| org.universAAL.ri.gateway.communicator.service.impl.GatewayCommunicatorImpl.handleMessage(InputStream, OutputStream) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 509 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Write to static field org.universAAL.ri.gateway.communicator.service.impl.SecurityManager.allowExportSecurityEntries from instance method org.universAAL.ri.gateway.communicator.service.impl.SecurityManager.setAllowExportSecurityEntries(Set) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 100 | High |
| Write to static field org.universAAL.ri.gateway.communicator.service.impl.SecurityManager.allowImportSecurityEntries from instance method org.universAAL.ri.gateway.communicator.service.impl.SecurityManager.setAllowImportSecurityEntries(Set) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 82 | High |
| Write to static field org.universAAL.ri.gateway.communicator.service.impl.SecurityManager.denyExportSecurityEntries from instance method org.universAAL.ri.gateway.communicator.service.impl.SecurityManager.setDenyExportSecurityEntries(Set) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 109 | High |
| Write to static field org.universAAL.ri.gateway.communicator.service.impl.SecurityManager.denyImportSecurityEntries from instance method org.universAAL.ri.gateway.communicator.service.impl.SecurityManager.setDenyImportSecurityEntries(Set) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 91 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in org.universAAL.ri.gateway.communicator.service.impl.SecurityUtils.initialize(String): String.getBytes() | I18N | DM_DEFAULT_ENCODING | 42 | High |
| Write to static field org.universAAL.ri.gateway.communicator.service.impl.SecurityUtils.key from instance method org.universAAL.ri.gateway.communicator.service.impl.SecurityUtils.initialize(String) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 42 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Write to static field org.universAAL.ri.gateway.communicator.service.impl.SocketCommunicationHandler.PORT from instance method new org.universAAL.ri.gateway.communicator.service.impl.SocketCommunicationHandler(GatewayCommunicator) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 64 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.universAAL.ri.gateway.eimanager.impl.ExportInterceptorsComparator implements Comparator but not Serializable | BAD_PRACTICE | SE_COMPARATOR_SHOULD_BE_SERIALIZABLE | 27-31 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Read of unwritten field exportPremises in org.universAAL.ri.gateway.eimanager.impl.ExportManagerImpl.addExportPremise(ExportPremise) | CORRECTNESS | NP_UNWRITTEN_FIELD | 82 | Medium |
| Read of unwritten field exportPremises in org.universAAL.ri.gateway.eimanager.impl.ExportManagerImpl.removeExportPremise(ExportPremise) | CORRECTNESS | NP_UNWRITTEN_FIELD | 86 | Medium |
| new org.universAAL.ri.gateway.eimanager.impl.ExportManagerImpl(GatewayCommunicator) invokes Thread.start() | MT_CORRECTNESS | SC_START_IN_CTOR | 62 | Medium |
| Unread field: org.universAAL.ri.gateway.eimanager.impl.ExportManagerImpl.communicator | PERFORMANCE | URF_UNREAD_FIELD | 56 | Medium |
| Unwritten field: org.universAAL.ri.gateway.eimanager.impl.ExportManagerImpl.exportPremises | CORRECTNESS | UWF_UNWRITTEN_FIELD | 82 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.universAAL.ri.gateway.eimanager.impl.ImportInterceptorsComparator implements Comparator but not Serializable | BAD_PRACTICE | SE_COMPARATOR_SHOULD_BE_SERIALIZABLE | 27-31 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Non-virtual method call in org.universAAL.ri.gateway.eimanager.impl.ImportManagerImpl.performInterceptorChainExecution(String, ImportRequest, EIOperationManager$Type) passes null for nonnull parameter of new org.universAAL.ri.gateway.eimanager.ImportEntry(String, BusMember, String, InternalImportOperation, boolean, String) | CORRECTNESS | NP_NULL_PARAM_DEREF_NONVIRTUAL | 179 | High |
| new org.universAAL.ri.gateway.eimanager.impl.ImportManagerImpl(GatewayCommunicator) invokes Thread.start() | MT_CORRECTNESS | SC_START_IN_CTOR | 79 | Medium |
| org.universAAL.ri.gateway.eimanager.impl.ImportManagerImpl.internalImportRemoteService(String, BusMember, String, String) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 220 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Switch statement found in org.universAAL.ri.gateway.eimanager.impl.exporting.ExportedProxyManager.registerProxies(ImportRequest) where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 114-149 | Medium |
| Unread field: org.universAAL.ri.gateway.eimanager.impl.exporting.ExportedProxyManager.contextBus | PERFORMANCE | URF_UNREAD_FIELD | 72 | Medium |
| org.universAAL.ri.gateway.eimanager.impl.exporting.ExportedProxyManager.reloadServices() makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 217 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.universAAL.ri.gateway.eimanager.impl.exporting.ProxyServiceCaller.serverNamespace | PERFORMANCE | URF_UNREAD_FIELD | 53 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.universAAL.ri.gateway.eimanager.impl.exporting.ProxyUICaller.getHandlerProfiles() may expose internal representation by returning ProxyUICaller.handlerProfiles | MALICIOUS_CODE | EI_EXPOSE_REP | 92 | Medium |
| new org.universAAL.ri.gateway.eimanager.impl.exporting.ProxyUICaller(ExportedProxyManager, String, ModuleContext, String, UIHandlerProfile[]) may expose internal representation by storing an externally mutable object into ProxyUICaller.handlerProfiles | MALICIOUS_CODE | EI_EXPOSE_REP2 | 44 | Medium |
| org.universAAL.ri.gateway.eimanager.impl.exporting.ProxyUICaller.setHandlerProfiles(UIHandlerProfile[]) may expose internal representation by storing an externally mutable object into ProxyUICaller.handlerProfiles | MALICIOUS_CODE | EI_EXPOSE_REP2 | 96 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.universAAL.ri.gateway.eimanager.impl.importing.ImportRequest.getCpe() may expose internal representation by returning ImportRequest.cpe | MALICIOUS_CODE | EI_EXPOSE_REP | 92 | Medium |
| org.universAAL.ri.gateway.eimanager.impl.importing.ImportRequest.getSubjectURIs() may expose internal representation by returning ImportRequest.subjectURI | MALICIOUS_CODE | EI_EXPOSE_REP | 113 | Medium |
| org.universAAL.ri.gateway.eimanager.impl.importing.ImportRequest.setCpe(String[]) may expose internal representation by storing an externally mutable object into ImportRequest.cpe | MALICIOUS_CODE | EI_EXPOSE_REP2 | 96 | Medium |
| org.universAAL.ri.gateway.eimanager.impl.importing.ImportRequest.setSubjectURIs(String[]) may expose internal representation by storing an externally mutable object into ImportRequest.subjectURI | MALICIOUS_CODE | EI_EXPOSE_REP2 | 117 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Switch statement found in org.universAAL.ri.gateway.eimanager.impl.importing.ImportedProxyManager.registerProxies(InternalImportOperation) where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 64-100 | Medium |
| org.universAAL.ri.gateway.eimanager.impl.importing.ImportedProxyManager.refreshProxy(ProxyRegistration) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 183 | Medium |
| org.universAAL.ri.gateway.eimanager.impl.importing.ImportedProxyManager.registerProxies(InternalImportOperation) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 69 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.universAAL.ri.gateway.eimanager.impl.importing.InternalImportOperation.getUiHandlerProfiles() may expose internal representation by returning InternalImportOperation.uiHandlerProfile | MALICIOUS_CODE | EI_EXPOSE_REP | 78 | Medium |
| org.universAAL.ri.gateway.eimanager.impl.importing.InternalImportOperation.setUiHandlerProfiles(UIHandlerProfile[]) may expose internal representation by storing an externally mutable object into InternalImportOperation.uiHandlerProfile | MALICIOUS_CODE | EI_EXPOSE_REP2 | 82 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Read of unwritten field publisher in org.universAAL.ri.gateway.eimanager.impl.importing.ProxyContextPublisher.removeProxy() | CORRECTNESS | NP_UNWRITTEN_FIELD | 50 | Medium |
| Unwritten field: org.universAAL.ri.gateway.eimanager.impl.importing.ProxyContextPublisher.publisher | CORRECTNESS | UWF_UNWRITTEN_FIELD | 50 | Medium |
